search

mikemccand / stargazers-migration-test

Testing Lucene's Jira -> GitHub issues migration
0 stars 0 forks source link

Deprecate getFieldNames from IndexWriter [LUCENE-8909] #906

Closed mikemccand closed 5 years ago

mikemccand commented 5 years ago

From SOLR-12368

Would be nice to be able to remove IndexWriter.getFieldNames as well, which was added in LUCENE-7659 only for this workaround.

Once Solr task resolved, deprecate IndexWriter#getFieldNames from 8x and remove it from master

Legacy Jira details

LUCENE-8909 by Munendra S N on Jul 10 2019, resolved Jul 18 2019 Attachments: LUCENE-8909.patch Linked issues:

mikemccand commented 5 years ago

+1

[Legacy Jira: Adrien Grand (@jpountz) on Jul 10 2019]

mikemccand commented 5 years ago

LUCENE-8909.patch

@jpountz could you please review the changes.txt? This patch is for master, will deprecate these methods in 8x

[Legacy Jira: Munendra S N on Jul 17 2019]

mikemccand commented 5 years ago

+1

[Legacy Jira: Adrien Grand (@jpountz) on Jul 17 2019]

mikemccand commented 5 years ago

Commit 6104f55ac0407258b096dfbf1fb81c20da580e0a in lucene-solr's branch refs/heads/master from Munendra S N https://gitbox.apache.org/repos/asf?p=lucene-solr.git;h=6104f55

LUCENE-8909: remove deprecated IndexWriter#getFieldNames()

[Legacy Jira: ASF subversion and git services on Jul 18 2019]

mikemccand commented 5 years ago

Commit d23da5a951c0ae9b1735c05c52e10f3fa0af2c7b in lucene-solr's branch refs/heads/branch_8x from Munendra S N https://gitbox.apache.org/repos/asf?p=lucene-solr.git;h=d23da5a

LUCENE-8909: deprecate IndexWriter#getFieldNames()

[Legacy Jira: ASF subversion and git services on Jul 18 2019]

mikemccand commented 3 years ago

Hi all,

I am interested in limiting the number of fields per index in a multi tenant environment. getFieldNames was an easy way to count the number of fields directly, without IndexReaders.

I would love to un-deprecate this method (or add a similar one). What do you think?

Thanks, Oren

[Legacy Jira: Oren Ovadia on Jan 14 2021]