mikemccand / stargazers-migration-test

Testing Lucene's Jira -> GitHub issues migration
0 stars 0 forks source link

Remove ICU dependency of nori tools/test-tools [LUCENE-8912] #909

Closed mikemccand closed 5 years ago

mikemccand commented 5 years ago

After this job, I'll apply LUCENE-8866 and LUCENE-8871 to Nori.

As mentioned in LUCENE-8904, I proceed this work from now on.

It is what @rmuir found first(LUCENE-8866) and then I just apply to Nori.

Nori doesn't need the ICU library because it uses Normalizer2 only for NFKC normalization like Kuromoji. I think it's OK to remove the library dependency because it can be handled by JDK.


Legacy Jira details

LUCENE-8912 by Namgyu Kim (@danmuzi) on Jul 11 2019, resolved Aug 08 2019

mikemccand commented 5 years ago

Commit b756cccf442e2998ab3dbef2616f6d980fbb59b5 in lucene-solr's branch refs/heads/master from Namgyu Kim https://gitbox.apache.org/repos/asf?p=lucene-solr.git;h=b756ccc

LUCENE-8912: remove nori/tools dependency on ICU

[Legacy Jira: ASF subversion and git services on Jul 23 2019]

mikemccand commented 5 years ago

Commit 2cabbf81524fc3e94e53a7a3f00c7419d484c838 in lucene-solr's branch refs/heads/branch_8x from Namgyu Kim https://gitbox.apache.org/repos/asf?p=lucene-solr.git;h=2cabbf8

LUCENE-8912: remove nori/tools dependency on ICU

[Legacy Jira: ASF subversion and git services on Aug 08 2019]

mikemccand commented 2 years ago

Closing after the 9.0.0 release

[Legacy Jira: Adrien Grand (@jpountz) on Dec 08 2021]