search

mikemccand / stargazers-migration-test

Testing Lucene's Jira -> GitHub issues migration
0 stars 0 forks source link

Cut Over To Set.copyOf and Set.Of From Collections.unmodifiableSet [LUCENE-8927] #924

Closed mikemccand closed 5 years ago

mikemccand commented 5 years ago

Legacy Jira details

LUCENE-8927 by Atri Sharma (@atris) on Jul 18 2019, resolved Jul 25 2019

mikemccand commented 5 years ago

Commit 3e2ca05b8eacbd81791daf950c4d56bfa971574d in lucene-solr's branch refs/heads/master from Atri Sharma https://gitbox.apache.org/repos/asf?p=lucene-solr.git;h=3e2ca05

LUCENE-8927: Set.copyOf and Set.of instead of Collections.unmodifiabl… (#796)

[Legacy Jira: ASF subversion and git services on Jul 25 2019]

mikemccand commented 5 years ago

Precommit fails for me, possibly due to this commit.

-ecj-javadoc-lint-src:
    [mkdir] Created dir: /tmp/ecj649495649
 [ecj-lint] Compiling 127 source files to /tmp/ecj649495649
 [ecj-lint] ----------
 [ecj-lint] 1. ERROR in /home/ishan/code/lucene-solr/lucene/benchmark/src/java/org/apache/lucene/benchmark/byTask/feeds/DemoHTMLParser.java (at line 23)
 [ecj-lint]     import java.util.Arrays;
 [ecj-lint]            ^^^^^^^^^^^^^^^^
 [ecj-lint] The import java.util.Arrays is never used
 [ecj-lint] ----------
 [ecj-lint] 2. ERROR in /home/ishan/code/lucene-solr/lucene/benchmark/src/java/org/apache/lucene/benchmark/byTask/feeds/DemoHTMLParser.java (at line 24)
 [ecj-lint]     import java.util.Collections;
 [ecj-lint]            ^^^^^^^^^^^^^^^^^^^^^
 [ecj-lint] The import java.util.Collections is never used
 [ecj-lint] ----------
 [ecj-lint] 3. ERROR in /home/ishan/code/lucene-solr/lucene/benchmark/src/java/org/apache/lucene/benchmark/byTask/feeds/DemoHTMLParser.java (at line 26)
 [ecj-lint]     import java.util.HashSet;
 [ecj-lint]            ^^^^^^^^^^^^^^^^^
 [ecj-lint] The import java.util.HashSet is never used
 [ecj-lint] ----------
 [ecj-lint] 3 problems (3 errors)

BUILD FAILED
/home/ishan/code/lucene-solr/build.xml:101: The following error occurred while executing this line:
/home/ishan/code/lucene-solr/lucene/build.xml:207: The following error occurred while executing this line:
/home/ishan/code/lucene-solr/lucene/common-build.xml:2181: The following error occurred while executing this line:
/home/ishan/code/lucene-solr/lucene/common-build.xml:2009: The following error occurred while executing this line:
/home/ishan/code/lucene-solr/lucene/common-build.xml:2048: Compile failed; see the compiler error output for details.

[Legacy Jira: Ishan Chattopadhyaya (@chatman) on Jul 25 2019]

mikemccand commented 5 years ago

Commit 90dd3f768fc97b569710188e3a38e9769e281f26 in lucene-solr's branch refs/heads/master from Ishan Chattopadhyaya https://gitbox.apache.org/repos/asf?p=lucene-solr.git;h=90dd3f7

LUCENE-8927: Fixing precommit / removing unused import

[Legacy Jira: ASF subversion and git services on Jul 25 2019]

mikemccand commented 5 years ago

Thanks for fixing @chatman!

[Legacy Jira: Adrien Grand (@jpountz) on Jul 26 2019]

mikemccand commented 5 years ago

Commit 3e2ca05b8eacbd81791daf950c4d56bfa971574d in lucene-solr's branch refs/heads/jira/SOLR-13650 from Atri Sharma https://gitbox.apache.org/repos/asf?p=lucene-solr.git;h=3e2ca05

LUCENE-8927: Set.copyOf and Set.of instead of Collections.unmodifiabl… (#796)

[Legacy Jira: ASF subversion and git services on Aug 01 2019]

mikemccand commented 5 years ago

Commit 90dd3f768fc97b569710188e3a38e9769e281f26 in lucene-solr's branch refs/heads/jira/SOLR-13650 from Ishan Chattopadhyaya https://gitbox.apache.org/repos/asf?p=lucene-solr.git;h=90dd3f7

LUCENE-8927: Fixing precommit / removing unused import

[Legacy Jira: ASF subversion and git services on Aug 01 2019]

mikemccand commented 2 years ago

Closing after the 9.0.0 release

[Legacy Jira: Adrien Grand (@jpountz) on Dec 08 2021]