search

mikemccand / stargazers-migration-test

Testing Lucene's Jira -> GitHub issues migration
0 stars 0 forks source link

Replace try-fail-catch test patterns [LUCENE-8938] #935

Closed mikemccand closed 5 years ago

mikemccand commented 5 years ago

Replace try-fail-catch test patterns with expectThrows wherever possible. This is spawned from SOLR-12555

Legacy Jira details

LUCENE-8938 by Munendra S N on Jul 29 2019, resolved Jul 29 2019 Attachments: LUCENE-8938.patch Linked issues:

mikemccand commented 5 years ago

LUCENE-8938.patch I have used expectThrowsAnyof when multiple exceptions can be thrown

[Legacy Jira: Munendra S N on Jul 29 2019]

mikemccand commented 5 years ago
✔ +1 overall
Vote Subsystem Runtime Comment
Prechecks
+1 test4tests 0m 0s The patch appears to include 24 new or modified test files.
master Compile Tests
+1 compile 2m 34s master passed
Patch Compile Tests
+1 compile 2m 16s the patch passed
+1 javac 2m 16s the patch passed
+1 Release audit (RAT) 1m 19s the patch passed
+1 Check forbidden APIs 0m 39s the patch passed
+1 Validate source patterns 0m 39s the patch passed
Other Tests
+1 unit 5m 15s common in the patch passed.
+1 unit 16m 34s core in the patch passed.
+1 unit 0m 38s join in the patch passed.
+1 unit 0m 28s queryparser in the patch passed.
+1 unit 0m 29s replicator in the patch passed.
+1 unit 2m 14s sandbox in the patch passed.
+1 unit 1m 17s suggest in the patch passed.
+1 unit 3m 4s test-framework in the patch passed.
38m 10s
Subsystem Report/Notes
JIRA Issue LUCENE-8938
JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12976090/LUCENE-8938.patch
Optional Tests compile javac unit ratsources checkforbiddenapis validatesourcepatterns
uname Linux lucene1-us-west 4.15.0-54-generic #58-Ubuntu SMP Mon Jun 24 10:55:24 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool ant
Personality /home/jenkins/jenkins-slave/workspace/PreCommit-LUCENE-Build/sourcedir/dev-tools/test-patch/lucene-solr-yetus-personality.sh
git revision master / b8289abeeb
ant version: Apache Ant(TM) version 1.10.5 compiled on March 28 2019
Default Java LTS
Test Results https://builds.apache.org/job/PreCommit-LUCENE-Build/200/testReport/
modules C: lucene/analysis/common lucene/core lucene/join lucene/queryparser lucene/replicator lucene/sandbox lucene/suggest lucene/test-framework U: lucene
Console output https://builds.apache.org/job/PreCommit-LUCENE-Build/200/console
Powered by Apache Yetus 0.7.0 http://yetus.apache.org

This message was automatically generated.

[Legacy Jira: Lucene/Solr QA on Jul 29 2019]

mikemccand commented 5 years ago

Commit 70a8deb0abedd42aec86b10a8da2676737853514 in lucene-solr's branch refs/heads/master from Munendra S N https://gitbox.apache.org/repos/asf?p=lucene-solr.git;h=70a8deb

LUCENE-8938: use expectThrows() to verify the ex thrown in tests

[Legacy Jira: ASF subversion and git services on Jul 29 2019]

mikemccand commented 5 years ago

Commit b82d345e2831a805bd0027289199d4e5935fa7c4 in lucene-solr's branch refs/heads/branch_8x from Munendra S N https://gitbox.apache.org/repos/asf?p=lucene-solr.git;h=b82d345

LUCENE-8938: use expectThrows() to verify the ex thrown in tests

[Legacy Jira: ASF subversion and git services on Jul 29 2019]