Closed mikemccand closed 4 years ago
mikemccand
commented
5 years ago Commit a9607b2a88185f03f95e7b0ab282336c8997488e in lucene-solr's branch refs/heads/master from Namgyu Kim https://gitbox.apache.org/repos/asf?p=lucene-solr.git;h=a9607b2
LUCENE-8954: refactor Nori analyzer
Signed-off-by: Namgyu Kim <namgyu@apache.org>
[Legacy Jira: ASF subversion and git services on Aug 26 2019]
mikemccand
commented
5 years ago Commit eb44ad324dba76b48d0e2b9011e3c76e93d3cc03 in lucene-solr's branch refs/heads/master from Tomas Eduardo Fernandez Lobbe https://gitbox.apache.org/repos/asf?p=lucene-solr.git;h=eb44ad3
LUCENE-8954: Fix precommit
[Legacy Jira: ASF subversion and git services on Aug 27 2019]
mikemccand
commented
4 years ago Commit 29b7e1a95c3a8857ef8ce05c0679c66e04b1f3e0 in lucene-solr's branch refs/heads/branch_8x from Namgyu Kim https://gitbox.apache.org/repos/asf?p=lucene-solr.git;h=29b7e1a
LUCENE-8954: refactor Nori analyzer
Signed-off-by: Namgyu Kim <namgyu@apache.org>
[Legacy Jira: ASF subversion and git services on Feb 24 2020]
mikemccand
commented
4 years ago Commit 904ba2540b3c7b9a1d19f70941bac62d822b2926 in lucene-solr's branch refs/heads/revert-1276-branch_8x from Namgyu Kim https://gitbox.apache.org/repos/asf?p=lucene-solr.git;h=904ba25
Revert "LUCENE-8954: refactor Nori analyzer"
This reverts commit 29b7e1a95c3a8857ef8ce05c0679c66e04b1f3e0.
[Legacy Jira: ASF subversion and git services on Feb 24 2020]
mikemccand
commented
4 years ago Commit 80372341426344f7d89a36adefbd178fb0e2548a in lucene-solr's branch refs/heads/branch_8x from Namgyu Kim https://gitbox.apache.org/repos/asf?p=lucene-solr.git;h=8037234
Revert "LUCENE-8954: refactor Nori analyzer"
This reverts commit 29b7e1a95c3a8857ef8ce05c0679c66e04b1f3e0.
[Legacy Jira: ASF subversion and git services on Feb 24 2020]
mikemccand
commented
4 years ago There is a lint error in patch. Sorry for confusing.
[Legacy Jira: Namgyu Kim (@danmuzi) on Feb 24 2020]
mikemccand
commented
4 years ago Commit b2796bf0c8361ed3069e587f94b4a1fa0eda7b32 in lucene-solr's branch refs/heads/branch_8x from Namgyu Kim https://gitbox.apache.org/repos/asf?p=lucene-solr.git;h=b2796bf
LUCENE-8954: refactor Nori analyzer
[Legacy Jira: ASF subversion and git services on Feb 25 2020]
mikemccand
commented
4 years ago Jenkins builds were completed well. https://jenkins.thetaphi.de/job/Lucene-Solr-8.x-Windows/806/ https://jenkins.thetaphi.de/job/Lucene-Solr-8.x-Linux/2262/ https://jenkins.thetaphi.de/job/Lucene-Solr-8.x-MacOSX/676/
[Legacy Jira: Namgyu Kim (@danmuzi) on Feb 26 2020]
mikemccand
commented
2 years ago Closing after the 9.0.0 release
[Legacy Jira: Adrien Grand (@jpountz) on Dec 08 2021]
There are many codes that can be refactored in the Nori analyzer. (whitespace, wrong type casting, unnecessary throws, C-style array, ...)
I think it's good to proceed if we can.
It has nothing to do with the actual working of Nori.
I'll just remove unnecessary code and make the code simple.
Legacy Jira details
LUCENE-8954 by Namgyu Kim (@danmuzi) on Aug 20 2019, resolved Feb 26 2020