search

mikemccand / stargazers-migration-test

Testing Lucene's Jira -> GitHub issues migration
0 stars 0 forks source link

Move compare logic to IntersectVisitor in NearestNeighbor [LUCENE-8955] #952

Closed mikemccand closed 4 years ago

mikemccand commented 4 years ago

Similar to LUCENE-8914, move compare logic to the IntersectVisitor so we can take advantage of the improvement added on LUCENE-7862. I ran the geoBenchmark for nearest 10 locally and the change provides an improvement of around 30%.

Legacy Jira details

LUCENE-8955 by Ignacio Vera (@iverase) on Aug 22 2019, resolved Aug 26 2019

mikemccand commented 4 years ago

Commit ff1e2fa6583724429bda7e469c622703a97408fa in lucene-solr's branch refs/heads/master from Ignacio Vera https://gitbox.apache.org/repos/asf?p=lucene-solr.git;h=ff1e2fa

LUCENE-8955: Move compare logic to IntersectVisitor in NearestNeighbor (#842)

[Legacy Jira: ASF subversion and git services on Aug 26 2019]

mikemccand commented 4 years ago

Commit d0ea612d4eafece77db76c12437978032fcd90e3 in lucene-solr's branch refs/heads/branch_8x from Ignacio Vera https://gitbox.apache.org/repos/asf?p=lucene-solr.git;h=d0ea612

LUCENE-8955: Move compare logic to IntersectVisitor in NearestNeighbor (#842)

[Legacy Jira: ASF subversion and git services on Aug 26 2019]

mikemccand commented 4 years ago

Nice speed up of 10 nearest points query on geo benchmarks (65%):

https://home.apache.org/~mikemccand/geobench.html#search-nearest_10

[Legacy Jira: Ignacio Vera (@iverase) on Aug 27 2019]