search

mikemccand / stargazers-migration-test

Testing Lucene's Jira -> GitHub issues migration
0 stars 0 forks source link

Code Cleanup: Use entryset for map iteration wherever possible - part 2 possible. [LUCENE-8979] #976

Closed mikemccand closed 5 years ago

mikemccand commented 5 years ago

For some reason, not all issues had been picked up in the previous ticket. This should be all of them. My bad I suppose.

 

==========================

 

Simple, non-important code cleanup.

Again, to clarify, please don't bother yourself with this ticket on company time, on personal time you could be working on something that makes you money or improves the product for your feature personally.

 

This entire ticket is an afterthough. A look back at the code base that most people don't have the time for.

 

================

 

While true that using entrySet() is really only an improvement for traversing a TreeMap(at least that's how it was in JDK8), it's a good practice in general to use it over keySet(), if you then use that keyset to do an extra lookup to get the value as well as the key.

 

So that's what this ticket is.

 

All changes were done automatically via Intellij's built-in code analysis.

 

Putting this on LUCENE because code both in lucene and solr was changed.

Legacy Jira details

LUCENE-8979 by Koen De Groote (@KoenDG) on Sep 15 2019, resolved Oct 14 2019 Linked issues:

mikemccand commented 5 years ago

Commit 04786244d0ae37eef88948c7fdfb5ccb84ca47da in lucene-solr's branch refs/heads/master from Koen De Groote https://gitbox.apache.org/repos/asf?p=lucene-solr.git;h=0478624

LUCENE-8979: Code Cleanup: Use entryset for map iteration wherever possible. - part 2

[Legacy Jira: ASF subversion and git services on Oct 14 2019]

mikemccand commented 5 years ago

Commit 0efd5e33d6c24ab2401d218e5d75dc2e9954d95d in lucene-solr's branch refs/heads/master from Adrien Grand https://gitbox.apache.org/repos/asf?p=lucene-solr.git;h=0efd5e3

LUCENE-8979: Move CHANGES entry to 8.4.

[Legacy Jira: ASF subversion and git services on Oct 14 2019]

mikemccand commented 5 years ago

Commit 93f9a093cc72251a09ac7c27468241a1deb68d6e in lucene-solr's branch refs/heads/branch_8x from Koen De Groote https://gitbox.apache.org/repos/asf?p=lucene-solr.git;h=93f9a09

LUCENE-8979: Code Cleanup: Use entryset for map iteration wherever possible. - part 2

[Legacy Jira: ASF subversion and git services on Oct 14 2019]

mikemccand commented 5 years ago

Thanks @KoenDG.

[Legacy Jira: Adrien Grand (@jpountz) on Oct 14 2019]

mikemccand commented 4 years ago

Closing after the 8.4.0 release.

[Legacy Jira: Adrien Grand (@jpountz) on Dec 29 2019]