search

mikemccand / stargazers-migration-test

Testing Lucene's Jira -> GitHub issues migration
0 stars 0 forks source link

Change Maven POM repository URLs to https [LUCENE-8993] #990

Closed mikemccand closed 5 years ago

mikemccand commented 5 years ago

After fixing LUCENE-8807 I figured out today, that Lucene's build system uses HTTPS URLs everywhere. But the POMs deployed to Maven central still use http (I assumed that those are inherited from the ANT build).

This will fix it for later versions by changing the POM templates. Hopefully this will not happen in Gradle!

[~markrmiller@gmail.com]: Can you make sure that the new Gradle build uses HTTPS for all hard configured repositories (like Cloudera)?

Legacy Jira details

LUCENE-8993 by Uwe Schindler (@uschindler) on Sep 29 2019, resolved Oct 01 2019 Attachments: LUCENE-8993.patch Linked issues:

mikemccand commented 5 years ago

Here is the patch: LUCENE-8993.patch

I cleaned my Maven Cache dir and rebuilt all using Maven. I grepped through the log files for "Downloading" with "http://" and got no match. All dependencies resolved correctly through Maven.

[Legacy Jira: Uwe Schindler (@uschindler) on Sep 29 2019]

mikemccand commented 5 years ago

FYI, the patch also updates some URLS already in HTTPS to be consistent with Lucene's ANT build. E.g., Cloudera is referring only to their "-local" repo, which contains only their artifacts, not all of Maven, so we do not pollute main repos with clones.

[Legacy Jira: Uwe Schindler (@uschindler) on Sep 29 2019]

mikemccand commented 5 years ago

Commit ee532099c12759775583c523a7cc5108ba864d23 in lucene-solr's branch refs/heads/master from Uwe Schindler https://gitbox.apache.org/repos/asf?p=lucene-solr.git;h=ee53209

LUCENE-8993: Change all repository references in Maven POM files to HTTPs; update some related URLs, too

[Legacy Jira: ASF subversion and git services on Oct 01 2019]

mikemccand commented 5 years ago

Commit 4a015e224dcd4b1c5f3db92c01d8bf80be3c244a in lucene-solr's branch refs/heads/branch_8x from Uwe Schindler https://gitbox.apache.org/repos/asf?p=lucene-solr.git;h=4a015e2

LUCENE-8993: Change all repository references in Maven POM files to HTTPs; update some related URLs, too

[Legacy Jira: ASF subversion and git services on Oct 01 2019]

mikemccand commented 5 years ago

I pushed the changes to master and 8.x. If we have further bugfix releases, especially of branches that contain LUCENE-8807, this should be cherry-picked (e.g., 8.1.2, or 8.2.1, or other). Any new release should have LUCENE-8807 and LUCENE-8993.

[Legacy Jira: Uwe Schindler (@uschindler) on Oct 01 2019]

mikemccand commented 5 years ago

For testing I deleted the ~/.m2/repository on ASF Jenkins. If the next Maven build works fine we are good.

[Legacy Jira: Uwe Schindler (@uschindler) on Oct 01 2019]

mikemccand commented 5 years ago

FYI, I’ve done this, though I’ll check stuff like this again before the merge to master.

[Legacy Jira: Mark Miller on Oct 02 2019]

mikemccand commented 5 years ago

After deleting the local Maven repos on Jnekins, I had to fix this issue again: https://issues.apache.org/jira/browse/LUCENE-2562?focusedCommentId=16816237&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-16816237

It looks like the Ant/Ivy build no longer works on a completely clean infrastructure (no maven repo, no ivy cache).

[Legacy Jira: Uwe Schindler (@uschindler) on Oct 02 2019]

mikemccand commented 5 years ago

Commit 2bdfc39d89c2633edf26271aca2809abe06af8f0 in lucene-solr's branch refs/heads/master from Uwe Schindler https://gitbox.apache.org/repos/asf?p=lucene-solr.git;h=2bdfc39

LUCENE-8993: Also update to latest version of Apache Parent POM

[Legacy Jira: ASF subversion and git services on Oct 03 2019]

mikemccand commented 5 years ago

Commit 9d21418dfcc5c884f45ab668579b0391965a18bb in lucene-solr's branch refs/heads/branch_8x from Uwe Schindler https://gitbox.apache.org/repos/asf?p=lucene-solr.git;h=9d21418

LUCENE-8993: Also update to latest version of Apache Parent POM

[Legacy Jira: ASF subversion and git services on Oct 03 2019]

mikemccand commented 5 years ago

I also updated the ASF parent POM to latest version.

[Legacy Jira: Uwe Schindler (@uschindler) on Oct 03 2019]

mikemccand commented 4 years ago

Commit fa726bec50ddbe1819a2d32c06aff3837b948e9e in lucene-solr's branch refs/heads/branch_8x from Uwe Schindler https://gitbox.apache.org/repos/asf?p=lucene-solr.git;h=fa726be

Revert "LUCENE-8993: Also update to latest version of Apache Parent POM"

This reverts commit 9d21418dfcc5c884f45ab668579b0391965a18bb.

This is needed because Lucene 8.x does not yet update minimum Maven version, but Apache Parent POM requires this.

[Legacy Jira: ASF subversion and git services on Oct 16 2019]

mikemccand commented 4 years ago

Commit 0c8e76764dd62728c61c415118584de04de6b022 in lucene-solr's branch refs/heads/branch_8_3 from Uwe Schindler https://gitbox.apache.org/repos/asf?p=lucene-solr.git;h=0c8e767

Revert "LUCENE-8993: Also update to latest version of Apache Parent POM"

This reverts commit 9d21418dfcc5c884f45ab668579b0391965a18bb.

This is needed because Lucene 8.x does not yet update minimum Maven version, but Apache Parent POM requires this.

[Legacy Jira: ASF subversion and git services on Oct 16 2019]

mikemccand commented 4 years ago

I had to revert the Apache Parent POM upgrade in 8.x and 8.3 branch, because the Apache Parent POM now needs a higher Maven minimum version, which we don't use yet in Lucene/Solr 8.

[Legacy Jira: Uwe Schindler (@uschindler) on Oct 16 2019]

mikemccand commented 2 years ago

Closing after the 9.0.0 release

[Legacy Jira: Adrien Grand (@jpountz) on Dec 08 2021]