search

mikemccand / stargazers-migration-test

Testing Lucene's Jira -> GitHub issues migration
0 stars 0 forks source link

Code Cleanup - Pass values to list constructor instead of empty constructor followed by addAll(). [LUCENE-8994] #991

Closed mikemccand closed 5 years ago

mikemccand commented 5 years ago

Trivial ticket, if your time is precious, feel free to skip.

 

In case of passing a collection into another, it's more efficient to pass the already existing collection into the constructor of the new one. It can usually deal with it more efficiently.

Legacy Jira details

LUCENE-8994 by Koen De Groote (@KoenDG) on Sep 30 2019, resolved Oct 14 2019

mikemccand commented 5 years ago

Commit e7e6cfaecfa44729bc7eae75a80493ec3e11944b in lucene-solr's branch refs/heads/master from Koen De Groote https://gitbox.apache.org/repos/asf?p=lucene-solr.git;h=e7e6cfa

LUCENE-8994: Code Cleanup - Pass values to list constructor instead of empty constructor followed by addAll(). (#919)

[Legacy Jira: ASF subversion and git services on Oct 14 2019]

mikemccand commented 5 years ago

Commit a40c0a2a42b46aa78cd1b8dec67bd4dadc594d41 in lucene-solr's branch refs/heads/master from Adrien Grand https://gitbox.apache.org/repos/asf?p=lucene-solr.git;h=a40c0a2

LUCENE-8994: Move CHANGES entry to 8.4.

[Legacy Jira: ASF subversion and git services on Oct 14 2019]

mikemccand commented 5 years ago

Commit 575f8a6ad8f462b0a61f0ea0d092bfebab1afce2 in lucene-solr's branch refs/heads/branch_8x from Koen De Groote https://gitbox.apache.org/repos/asf?p=lucene-solr.git;h=575f8a6

LUCENE-8994: Code Cleanup - Pass values to list constructor instead of empty constructor followed by addAll(). (#919)

[Legacy Jira: ASF subversion and git services on Oct 14 2019]

mikemccand commented 5 years ago

Thanks @KoenDG.

[Legacy Jira: Adrien Grand (@jpountz) on Oct 14 2019]

mikemccand commented 4 years ago

Closing after the 8.4.0 release.

[Legacy Jira: Adrien Grand (@jpountz) on Dec 29 2019]