Fix with NG_HIDE_CLASS variable in aclShow directive.

mikemclin / angular-acl

Role-based permissions for AngularJS

196 stars 49 forks source link

Fix with NG_HIDE_CLASS variable in aclShow directive. #28

Closed sindhushaballa closed 7 years ago

sindhushaballa commented 7 years ago

Hi,

Please merge this request if you are fine with the changes.

coveralls commented 7 years ago

Changes Unknown when pulling b06c72676957db8ec3213535299364780b6ba492 on bsurendrakumar:0.1.8-fix into on mikemclin:master.

coveralls commented 7 years ago

Changes Unknown when pulling a0f1cd2c388cf59a9c273ac01d8a0547af70389f on bsurendrakumar:0.1.8-fix into on mikemclin:master.

mikemclin commented 7 years ago

Actually, this issue is that I placed the NG_HIDE_CLASS inside of the provider function, so it wasn't available to the directive. I am going to move it to the global scope, and remove it from being an injected constant, similar to how it is handled by Angular - https://github.com/angular/angular.js/blob/master/src/ng/directive/ngShowHide.js

mikemclin commented 7 years ago

Thanks for the contribution!

sindhushaballa commented 7 years ago

Hi @mikemclin

You are welcome and it's a good plugin.