mikemountain / nfl-led-scoreboard

NFL LED scoreboard! This project can display live scores of your favourite football teams!
GNU General Public License v3.0
100 stars 29 forks source link

Schema for Validation Purposes and `led-board-manager` integration #26

Open sflems opened 3 years ago

sflems commented 3 years ago

Is your feature request related to a problem? Please describe. No. This could enhance validation and board management for users.

Describe the solution you'd like Schema file would define required config.json settings with NFL board settings. Could be expanded to validate similar to NHL board.

Describe alternatives you've considered Schema could be provided with led-board-manager. Adding to NFL project would make it available for validators and as a reference for the config.json.

Additional context I've generated a schema for the config that would allow easy integration to manage boards and generate config forms in the led-board-manager app. This does not affect the core in any way and future features added to this schema would dynamically update any added validation as well as user forms for config generation/validation and hot-swapping boards.

No harm no foul if you'd like to exclude it. Or let me know, and I could look into adding config validation. See also PR #25.

Cheers!