mikemtzp / My-Portfolio

Here you can access my portfolio where I introduce myself and showcase all the relevant projects I'm currently working on. Built with JavaScript.
https://mikemtzp.github.io/My-Portfolio/
4 stars 0 forks source link

Peer-to-Peer code review #8

Open IsaMarvin opened 2 years ago

IsaMarvin commented 2 years ago

Hi there 👋

you can easily use a .font class in multiple places or simply put the font-family property in the body selector and all other children elements going to inherit it by default.

css .menu { / ...code / font-family: Arial, Helvetica, sans-serif; / ...code / }

.w1-title { / ...code / font-family: Arial sans-serif; / ...code / }

css .font { font-family: inter, sans-serif; }

Note: Also, you can do the same thing with the display: flex declaration.

ogiogiovictor commented 2 years ago

I think the code is great, Good job Mike however, you can apply the pseudo selector :root for classes that are the same so you don't repeat same css style. I am also during that currently in mine code base and i think its very nice.

masangana commented 2 years ago

very good job. Very impressed. It would surely be better if you could name your classes in more telling ways. For example work1-title instead of w1-title And I love your work. You challenge me 👍