search

mikenicholson / passport-jwt

Passport authentication using JSON Web Tokens
MIT License
1.96k stars 213 forks source link

Enhancement to options: #113

Closed itayadler closed 7 years ago

itayadler commented 7 years ago

Added jsonWebTokenOptions to options, which allows one to pass additional options to node-jsonwebtoken verifier. This way there won't be a need to change passport-jwt for any other custom option used in the verifier.

itayadler commented 7 years ago

ping :) What do you guys think of this PR?

itayadler commented 7 years ago

ping..

andrewbrazzatti commented 7 years ago

We were about to fork and make the same changes. It'd be great if these could be merged in!

shilob commented 7 years ago

Any chance this gets merged and published soon?

itayadler commented 7 years ago

pong

itayadler commented 7 years ago

pong..

mikenicholson commented 7 years ago

Sorry for neglecting the project for so long and thanks for reaching out.

I have a few more big changes to merge and will release a major version rev shortly. Normally i would release right away but I don't want to release multiple major versions one after another.