search

mikenicholson / passport-jwt

Passport authentication using JSON Web Tokens
MIT License
1.96k stars 213 forks source link

handle missing token with error instead of fail #163

Closed kcberg closed 5 years ago

kcberg commented 6 years ago

should address.. https://github.com/themikenicholson/passport-jwt/issues/160

Mhowell494 commented 6 years ago

Is this going to get merged any time soon? Really annoying problem.

jerroydmoore commented 5 years ago

I came here to report the same problem. If this project is abandoned, it might be time to fork a copy so we can continue to maintain the code base. Otherwise, this project isn't suitable for production use.

kcberg commented 5 years ago

@jerroydmoore It does seem like it's not being maintained. Let me contact some folks I know at Auth0 and see what I can figure out.

mikenicholson commented 5 years ago

I'll take a look at this in the next two days. No intent to abandon, I just generally watch the incoming issues via email and missed this in the noise of "Help me figure out how to write my app" issues.

kcberg commented 5 years ago

Thanks @themikenicholson I'm happy to help out anyway I can!

mikenicholson commented 5 years ago

Thanks.

I need to write a contributing.md and just get better about closing down the issues that belong on stack overflow/aren't accompanied with a test or small, functioning reproduction case. That would prevent that from hiding real issues like this.

jerroydmoore commented 5 years ago

Also willing to help where I can. Though, I've only just started using passport-jwt

mikenicholson commented 5 years ago

See my comment on #160, Based on the documentation of passport-strategy and the example of passport-local I think that we're already doing the right thing.

mikenicholson commented 5 years ago

Closing based on discussion in #160.