adding Promise handling to jwtFromRequest result, type checking on result and error handling for new functionality.

mikenicholson / passport-jwt

Passport authentication using JSON Web Tokens

MIT License

1.96k stars 213 forks source link

Open sbaker opened 4 years ago

sbaker commented 4 years ago

adding Promise functionality in _jwtFromRequest result and adding unit tests to support new functionality this fixes issue #186

sbaker commented 4 years ago

Hi, @mikenicholson I was wondering if you've had a chance to review this PR?

DocLM commented 3 years ago

nlopezm commented 3 years ago

Hi, @mikenicholson I would really appreciate it if you can take a look at this PR. I need to be able to pass a Promise to jwtFromRequest. Thanks!

sbaker commented 3 years ago

Great point! Thanks!

Outternet commented 1 year ago

This is a good idea, I have adopted your implemetation in the major rewrite pull request.