mikenicholson / passport-jwt

Passport authentication using JSON Web Tokens
MIT License
1.97k stars 215 forks source link

adding Promise handling to jwtFromRequest result, type checking on result and error handling for new functionality. #187

Open sbaker opened 5 years ago

sbaker commented 5 years ago

adding Promise functionality in _jwtFromRequest result and adding unit tests to support new functionality this fixes issue #186

sbaker commented 5 years ago

Hi, @mikenicholson I was wondering if you've had a chance to review this PR?

DocLM commented 4 years ago

+1

nlopezm commented 3 years ago

Hi, @mikenicholson I would really appreciate it if you can take a look at this PR. I need to be able to pass a Promise to jwtFromRequest. Thanks!

sbaker commented 3 years ago

Great point! Thanks!

Outternet commented 2 years ago

This is a good idea, I have adopted your implemetation in the major rewrite pull request.