lib/strategy: Add failWithError support

mikenicholson / passport-jwt

Passport authentication using JSON Web Tokens

MIT License

1.96k stars 213 forks source link

lib/strategy: Add failWithError support #224

Open emdemir opened 3 years ago

emdemir commented 3 years ago

The failWithError option tells the strategy to not fail but pass instead when authentication fails. This commit makes passport-jwt respect this setting.

canslaughter commented 1 year ago

Passport already handles failWithError quite well and strategy.pass has nothing to do with it. This is just wrong.

Outternet commented 1 year ago

Could you elaborate on your idea, as I currently agree with the rest of the comments.