search

mikeoliphant / neural-amp-modeler-lv2

Neural Amp Modeler LV2 plugin implementation
GNU General Public License v3.0
227 stars 28 forks source link

Publishing this plugin on Flathub: You or me? :) #33

Closed runiq closed 1 year ago

runiq commented 1 year ago

Like I mentioned before, I'm trying to build your plugin as a Flatpak so I can use it with Flatpak'd Ardour and friends. I've gotten a first working version here.

Before I go ahead and upload your plugin to Flathub, I would like to ask if you want to do it yourself (in accordance with Flathub's submission guidelines). There are a few requirements, but they can easily be met, seeing how lots of other audio plugins are already on Flathub.

mikeoliphant commented 1 year ago

Is it something that can be automated via GitHub actions?

runiq commented 1 year ago

I'm not sure, but I'm fairly confident it can. Haven't ever had to deal with GH actions, to be honest.

mikeoliphant commented 1 year ago

How about you go ahead and get it set up. If I get more established releases going at some point, it might make sense to try to integrate it more then.

runiq commented 1 year ago

Great, I will! Flathub also have some Github actions available. I have yet to find out if they help with publishing, though.

mikeoliphant commented 1 year ago

👍

runiq commented 1 year ago

I'm going through the requirements and almost everything looks good. There's just one little thing: Flathub only allows publishing Git tags.

Would you consider tagging a commit?

mikeoliphant commented 1 year ago

Ok, I cut a release and generated a tag.

runiq commented 1 year ago

Alright, done: https://github.com/flathub/flathub/pull/4271

mikeoliphant commented 1 year ago

👍

runiq commented 1 year ago

Okay, done. I'll ask them to make you a maintainer for that repo as well, so you can merge PRs etc.

Whenever you publish a new release in this here repo, a corresponding PR on the nam.lv2 Flathub repo will be created by a bot. It currently has to be merged manually, but it can also be configured to auto-merge upon a successful build.

For everything else, see the Flathub maintenance docs. I'd be happy to maintain the Flatpak if you want, though.

mikeoliphant commented 1 year ago

Sounds good - thanks!