search

mikepenz / AboutLibraries

AboutLibraries automatically collects all dependencies and licenses of any gradle project (Kotlin MultiPlatform), and provides easy to integrate UI components for Android and Compose-jb environments
http://mikepenz.github.io/AboutLibraries/
Apache License 2.0
3.66k stars 423 forks source link

Some licenses are not recognized #460

Closed koral-- closed 4 years ago

koral-- commented 4 years ago

Follow-up of https://github.com/mikepenz/AboutLibraries/issues/458 Steps to reproduce and configuration is the same except for About Libraries version which is now 8.0.0-a03

Libs which I've found not working:

mikepenz commented 4 years ago

thank you so much. :) I will have a look at those libs and see to get them handled too

mikepenz commented 4 years ago

https://jcenter.bintray.com/com/tbuonomo/andrui/viewpagerdotsindicator/4.1.2/ has no license at all specified :/

koral-- commented 4 years ago

In repo there is Apache v2: https://github.com/tommybuonomo/dotsindicator/blob/master/LICENSE it is sent also to bintray: https://github.com/tommybuonomo/dotsindicator/blob/master/viewpagerdotsindicator/deploy.gradle#L33 but does not seem to be added to POM: https://github.com/tommybuonomo/dotsindicator/blob/ad9b4c4759bf1744914895ff6d05cb115fb2b448/viewpagerdotsindicator/deploy.gradle#L40

PR or issue in that repo is needed.

mikepenz commented 4 years ago

I made the experience in most cases those issues will not lead to any proper resolution. for that matter I will construct a flexible way to have available information be possible to inject.

a property file for: license library name

and a property file to map: available_custom_definition_file with the resolved information from the pom

this will still happen automatically behind the scenes.

mikepenz commented 4 years ago

This should be fixed now at least for most parts :)

koral-- commented 4 years ago

I've added an issue to https://github.com/tommybuonomo/dotsindicator (linked above). Autovalue has license defined in parent POM (the same case with another library is also in #461).

Rest of the cases seems to be covered by recent changes, so this issue may be probably closed.