mikepenz / AboutLibraries

AboutLibraries automatically collects all dependencies and licenses of any gradle project (Kotlin MultiPlatform), and provides easy to integrate UI components for Android and Compose-jb environments
http://mikepenz.github.io/AboutLibraries/
Apache License 2.0
3.62k stars 419 forks source link

Apache-2.0 License in generated JSON file may have invalid "url" #907

Closed rocka closed 1 year ago

rocka commented 1 year ago

About this issue

In the generated JSON file, "Apache-2.0" license may have an invalid "url" field, which value is "apache_2_0", rather than "https://spdx.org/licenses/Apache-2.0.html" or "https://spdx.org/licenses/Apache-2.0.txt".

This affects the sample application as well, if you download AboutLibraries-v10.8.2-c100820-release.apk in https://github.com/mikepenz/AboutLibraries/releases/tag/v10.8.2 , extract res/iz.json file, jump to line 2338, you can see the "url":

image

We are using the core module only, and consume the JSON file by

Libs.Builder()
    .withJson(jsonString)
    .build()

then open license.url in browser, such url could cause an exception and crash the App.

Details

mikepenz commented 1 year ago

Thank you very much for the report.

There will be a fixed plugin version released soon.