mikepenz / AboutLibraries

AboutLibraries automatically collects all dependencies and licenses of any gradle project (Kotlin MultiPlatform), and provides easy to integrate UI components for Android and Compose-jb environments
http://mikepenz.github.io/AboutLibraries/
Apache License 2.0
3.62k stars 419 forks source link

Duplicate "AboutLibraries Library" listed #949

Closed RyeGordo closed 7 months ago

RyeGordo commented 7 months ago

Duplicate "AboutLibraries Library"

The AboutLibraries lib is listed twice.

Implemented via Compose

LibrariesContainer(Modifier.fillMaxSize())

added com.mikepenz:aboutlibraries-compose-m3 added com.mikepenz.aboutlibraries.plugin

Details

Checklist

mikepenz commented 7 months ago

Thank you @RyeGordo that's because it lists every single module of your app.

there is the compose-m3 module and the core module, which both are listed.

Will look to adjust the title for the Material 3 lib variant.

You can also configure this behavior in the plugin settings: https://github.com/mikepenz/AboutLibraries?tab=readme-ov-file#gradle-plugin-configuration

By default it will keep duplicates:

var duplicationMode = DuplicateMode.KEEP

But you can change it to MERGE duplicates.

The default mode is SIMPLE (groupId and title to be equal)

var duplicationRule = DuplicateRule.SIMPLE

https://github.com/mikepenz/AboutLibraries/blob/develop/plugin-build/plugin/src/main/kotlin/com/mikepenz/aboutlibraries/plugin/AboutLibrariesExtension.kt

RyeGordo commented 7 months ago

Thanks for your quick response.

To clarify, I'm not using the core module, only the compose-m3.

On Thu, Jan 25, 2024, 04:31 Mike Penz @.***> wrote:

Reopened #949 https://github.com/mikepenz/AboutLibraries/issues/949.

— Reply to this email directly, view it on GitHub https://github.com/mikepenz/AboutLibraries/issues/949#event-11594731991, or unsubscribe https://github.com/notifications/unsubscribe-auth/AJMNQGRTNZWOKDWOPOHH4SLYQIQ7JAVCNFSM6AAAAABCJWXANWVHI2DSMVQWIX3LMV45UABCJFZXG5LFIV3GK3TUJZXXI2LGNFRWC5DJN5XDWMJRGU4TINZTGE4TSMI . You are receiving this because you were mentioned.Message ID: @.***>

mikepenz commented 7 months ago

Which depends on the core module: https://github.com/mikepenz/AboutLibraries/blob/develop/aboutlibraries-compose-m3/build.gradle.kts#L111

RyeGordo commented 7 months ago

Thanks for the clarification.

And allow me to take this opportunity to commend you on a wonderful library. The UI is very nice. Well done.

On Thu, Jan 25, 2024, 05:59 Mike Penz @.***> wrote:

Which depends on the core module: https://github.com/mikepenz/AboutLibraries/blob/develop/aboutlibraries-compose-m3/build.gradle.kts#L111

— Reply to this email directly, view it on GitHub https://github.com/mikepenz/AboutLibraries/issues/949#issuecomment-1909920232, or unsubscribe https://github.com/notifications/unsubscribe-auth/AJMNQGQ6MQ3SIUVIQPZCBKTYQI3IRAVCNFSM6AAAAABCJWXANWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSMBZHEZDAMRTGI . You are receiving this because you were mentioned.Message ID: @.***>

mikepenz commented 7 months ago

Thank you very much!

The next release will now also have different names for the individual modules for more clarity.