search

mikepenz / FastAdapter

The bullet proof, fast and easy to use adapter library, which minimizes developing time to a fraction...
https://mikepenz.dev
Apache License 2.0
3.84k stars 493 forks source link

Items size not being adjusted on custom DPI settings #82

Closed franciscofranco closed 8 years ago

franciscofranco commented 8 years ago

I'm not sure this is something you can fix, or even something you can reproduce, but I'm using FastAdapter on this mutative design open source project and I had this one user describing a weird bug while using the adapter. Check here for the issue + video: https://github.com/liamspradlin/Phoebe/issues/5

Again, I'm not sure this is something on your side, just though of bringing it up. I can't reproduce on my stock-dpi devices (tried on all Nexus devices since the Galaxy Nexus, One Plus 2, One Plus X and Nextbit Robin).

mikepenz commented 8 years ago

@franciscofranco I have the weird feeling that it may be related to the ItemAnimator or that it is caused by the LayoutManager. Perhaps from the StaggeredGridLayoutManager and a wrong messurement.

I am pretty sure it is unrelated to the FastAdapter itself as the Adapter just provides the items, but does not handle positioning, nor animations. The items themself follow the ViewHolder pattern and just provide the general view, which is also unrelated to the positioning.

You assumption that it may be the custom DPI could be true.

mikepenz commented 8 years ago

@franciscofranco already found something new about this issue?

franciscofranco commented 8 years ago

Not yet, haven't had the time yet. I'll contact you on Slack about it

mikepenz commented 8 years ago

@franciscofranco ok fine.

mikepenz commented 8 years ago

I think I can safely close this issue as I am pretty sure it is unrelated. If we find the root cause or a solution we can still answer it here.