README.md does not reflect current library - Githubissues

mikepenz / MaterialDrawer

The flexible, easy to use, all in one drawer library for your Android project. Now brand new with material 2 design.

https://mikepenz.dev

Apache License 2.0

11.67k stars 2.05k forks source link

README.md does not reflect current library #2710

Closed clydebarrow closed 3 years ago

clydebarrow commented 3 years ago

About this issue

The README.md suggests using this pattern to construct drawer items:
```
val item1 = PrimaryDrawerItem().withIdentifier(1).withName(R.string.drawer_item_home)
```
But this produces deprecation messages. I saw nothing in the Migration Guide to help. The sample app does have the newer syntax. Either the README.md should be updated with the current syntax, or suggestions there should be removed.

Details

[x] Used library version - 8.1.3
[x] Used support library version - using AndroidX
[x] Used gradle build tools version 4.0.2

Checklist

[x] Searched for similar issues
[x] Checked out the sample application
[x] Read the README
[x] Checked out the CHANGELOG
[x] Read the FAQ
[x] Checked out the MIGRATION GUIDE

mikepenz commented 3 years ago

Thank you so much for the @clydebarrow ticket. updated the README to also reflect the new syntax