mikepenz / action-junit-report

Reports junit test results as GitHub Pull Request Check
https://blog.mikepenz.dev
Apache License 2.0
305 stars 116 forks source link

missing mypy detail when annotate_only=true #1049

Closed Alex-ley-scrub closed 6 months ago

Alex-ley-scrub commented 6 months ago

as briefly mentioned in: https://github.com/mikepenz/action-junit-report/issues/699#issuecomment-1983734072

basically when you have annotate_only=false (the default) you see something like this (similar to the repo README images):

and when you click "Raw Output" button you see the mypy error:

image

but with annotate_only=true you don't have the "Raw Output" button and therefore can't see the erorr

image
mikepenz commented 6 months ago

Upon a closer look, this is unfortunately a limitation from GitHub. There is a difference if a check is created, or if a normal annotation is built.

For the annotate_only a annotation property can be provided, and these don't allow for any additional information.

While check do allow an additional raw_details to bo be provided

mikepenz commented 6 months ago

The only "alternative" I could think of would be to add the stacktrace as part of the message for the annotation, however not everyone may like that as it is quite verbose and there is no collapsing for it

mikepenz commented 6 months ago

@Alex-ley-scrub related the summary output: https://github.com/mikepenz/action-junit-report/pull/1050 It would be great if you could try it out if it matches what you needed.

mikepenz commented 6 months ago

Closing as we won't be able to have the same output for annotation_only.