mikeperri / flutter_sequencer

A Flutter plugin for music sequencing.
Other
91 stars 39 forks source link

There is no sound in release mode but it works perfectly in debug mode [tested on iOS simulator and 2 iPhones] #31

Closed yasinarik closed 2 years ago

yasinarik commented 2 years ago

Thanks a lot

Hi @mikeperri. Thank you for creating and sharing this package. The reason I want to use this package is that I need an audio library that provides very low latency playback and thankfully it does. I am also a music producer for more than 10 years. I can't stress the importance of low latency enough.

The Issue

In short, I can't make it work in release mode neither on iOS simulator nor 2 different iPhones. (Soundfonts - SF2. I tried other instrument types too).

Also I successfully uploaded the app to TestFlight and started testing on devices but no sound.

In debug mode, it runs smoothly and as expected on both iOS simulator and iPhones. I even expected and I would accept that there could be some more latency in debug mode but it is fairly good.

I am at almost end of a project and the last part is sound designing and it's like I bet all the odds on this package. So if you have time, could you please try to understand what could be the reason?

Maybe there is some basic config change could solve this. I have carefully checked all the other issues and forks/PRs of other people.

mikeperri commented 2 years ago

Hi Yasin, thanks for reaching out! I'll get back to you in the next few days. I am aware of this issue. I know @maestrocoder was able to fix it.

yasinarik commented 2 years ago

Hi Yasin, thanks for reaching out! I'll get back to you in the next few days. I am aware of this issue. I know @maestrocoder was able to fix it.

Appreciated! Also thanks for answering that quick.

I will be looking forward to hearing from you.

mikeperri commented 2 years ago

Hi @yasinarik, you might have to downgrade to version 0.3.2 for now. @maestrocoder is using a fork from version 0.3.2 in his production app, so I know that will work. I think the only changes from his fork are related to the Android build. He's going to make a pull request sometime soon, but until then, you can use his version. In your pubspec, you'd do:

flutter_sequencer:
    git:
      url: https://github.com/VoiceLessons/flutter_sequencer.git
      ref: f5de29a0a4a069d31bc7a6407f620765146dde61

The latest version is 0.4.3. There are some breaking changes between 0.3 and 0.4, so it might take a little work on your end to downgrade, but if you're not dependent on the 0.4 features then I'd suggest doing that so you can move forward ASAP. In the meantime, I'll look into what the issue is with the iOS release mode on 0.4.

mikeperri commented 2 years ago

@yasinarik I just published a new version, 0.4.4, which I think fixes the issue in release mode. I just added back this pod target XCConfig setting, "ENABLE_TESTABILITY", which I had in 0.3.2 but removed for some reason. After doing that, I was able to launch the example app in release mode on an iPhone from XCode, and there were no issues. Let me know if it works for you!

yasinarik commented 2 years ago

@mikeperri Thank you for caring!

I just saw the notification now. Very good news.

I will test both versions and let you know the result asap. (Actually I would like to do it now but I'm not feeling well since last night)

yasinarik commented 2 years ago

Thank you very much @mikeperri for your outstanding work, and also @maestrocoder. I can have it working on an iOS device in release mode. I haven't tested if it works in builds from TestFlight but it probably will. Sorry for that I am late to test it and reply but I was sick.

The version that I use is: flutter_sequencer: ^0.4.4

I was planning to release an update for my app that is currently available on AppStore. Hopefully, I will implement the audio features into this update with the help of Flutter_Sequencer.

Moyck commented 2 years ago

@yasinarik Will the TestFlight build work correctly? I use flutter_sequencer: ^0.4.4 Everything works fine in release mode, but no sound can be played in TestFlight