mikepj / XRG

System monitor for macOS.
https://gaucho.software/xrg/
GNU General Public License v2.0
298 stars 51 forks source link

Graph text anti-aliasing is inconsistent #24

Closed dogcow closed 1 year ago

dogcow commented 1 year ago

I see two bugs:

  1. No text in the graphs respect the "Appearance > Graph Text > Anti-alias" checkbox.
  2. Some text in the graphs respect the "General > Graph Window General Appearance > Enable Anti-Aliasing When Drawing Graphs" checkbox, I would expect all graph text to be controlled by the "Appearance > Graph Text > Anti-alias" checkbox.

Fields affected by item 2 are:

Screenshot 2023-03-09 at 11 58 44 AM

mikepj commented 1 year ago

Going to close this as wontfix. Sorry to remove this feature, but later versions of macOS don't support custom anti-aliasing settings for NSTextFields, which XRG will now use for drawing a lot of the text in the graph window. Unfortunately the only way to keep text anti-aliasing configurable would be to return to a slower text drawing method. In order for text to be consistent across all the views, I'm removing the option to disable anti-aliasing for graph text. This change will take place in XRG version 3.2.1.

Thanks for the the bug report. Sorry it's probably not the outcome you were looking for.

dogcow commented 1 year ago

Losing custom anti-aliasing provided by those checkboxes is fine. :)

I would like to point out that with the latest release the text circled above is still rendered differently than the rest of the text. It would be nice to have the rendering consistent between graphs.

mikepj commented 1 year ago

I've corrected the GPU graph. The network and disk graphs use different logic to draw because they have bottom-aligned text. It's a bigger refactor to fix that one.