search

mikepqr / resume.md

Write your resume in Markdown, style it with CSS, output to HTML and PDF
MIT License
569 stars 229 forks source link

Headers & Footers on latest Chrome #41

Closed alpaca1thunder closed 11 months ago

alpaca1thunder commented 11 months ago

Hey, apologies for the brief issue report. I'm using this to help with a school assignment and have to get back to writing it.

I tried with the latest Google Chrome on macOS (120.0.6099.62, installed with brew) , and with the Chromium that ships with the latest Debian stable (120.0.6099.71, tried via a Docker container), and it seems to print headers and footers on the output pdf.

I'm able to generate the expected pdf by pulling in a earlier debian container (buster) that ships with version 90 or so of Chromium, and I'm able to generate a correct pdf with that. I'm assuming it worked with 119, and broke with 120.

Thanks for this wonderful project! Let me know if I can help at all.

mikepqr commented 11 months ago

Ah. Thanks for the report! Looks like they renamed the option.

Can you try changing the string on line 130 of resume.py to --no-pdf-header-footer and let me know if that works?

If you can't figure out how to do that, or that doesn't work, let me know and I'll take a closer look.

alpaca1thunder commented 11 months ago

Ah. Thanks for the report! Looks like they renamed the option.

Can you try changing the string on line 130 of resume.py to --no-pdf-header-footer and let me know if that works?

If you can't figure out how to do that, or that doesn't work, let me know and I'll take a closer look.

That worked! Thanks for the prompt reply. I'll create a PR with that change.