codepathreview
commented
9 years ago :+1: Project looks great. Good job implementing so many optionals, the UI also looks very polished
- Good use of view holder pattern inside adapter
- Good to see you properly communicated the user to the user timeline fragment from the profile activity.
- Nicely done architecting the home and mentions tabs, having one Fragment support multiple types.
- Nice to see you used the ViewPager to properly setup the tabs!
- Good to see you played with styling a bit
- Nice use of tag to setup the ability to click the profile image and view a user's profile
- Consider adding progress bars to your app whenever a network request goes out
I have provided a detailed Project 4 Feedback Guide here which covers the most common issues with this submitted project. Read through the feedback guide point-by-point to determine how you might be able to improve your submission.
Let us know if you have any other thoughts or questions about this assignment. Hopefully you can see this coming together as a "fully fledged" twitter client with some more work and polish. This app contains all of the components now (fragments, models, networking, client, tab navigation, image loading, et al) of 90% of dynamic data-driven API client. Obviously there are lots of details and patterns to learn, but by this point you have been introduced to all the major frameworks and concepts. Hopefully you would feel fairly confident getting started making Android apps for instagram, pinterest, yardsale, flickr using the same patterns.
Re-submitted assignment 4 on a new repo, please review. /cc @codepathreview and @codepath