Deprecate PHP version before 7.4

mikepultz / netdns2

Native PHP DNS Resolver and Updater

https://netdns2.com/

Other

119 stars 64 forks source link

Deprecate PHP version before 7.4 #142

Closed arnowelzel closed 1 year ago

arnowelzel commented 1 year ago

The README still says "PHP 5.4+" as requirement. However PHP 5.4 is way outdated and even PHP 7.4 is end of life:

https://www.php.net/supported-versions.php

Since even PHP 8.0 is already in its "Security fixes only" you should consider dropping support for PHP versions older than 7.4. This would make it much easier to use modern language elements of PHP like the null coalescing operator, anonymous classes etc.. Also see https://www.php.net/manual/en/migration70.new-features.php#migration70.new-features.null-coalesce-op

mikepultz commented 1 year ago

The 1.5.x branch is going to stay as PHP 5.4+; 1.6.x will be newer.

Mike

arnowelzel commented 1 year ago

Some questions here:

is the master branch not the newest version (1.6.x)?
at the moment https://github.com/mikepultz/netdns2/blob/version-1.6.x/README.md also says "PHP 5.4+". Is an update to newer versions planned for the future versions?

mikepultz commented 1 year ago

Neither the master branch nor the 1.6.x branch are up-to-date; once I have a version that isn't broken, I'm going to commit to 1.6.x and merge into master, but I didn't want to do that until it was at least syntactically valid.

Currently, the only valid version is out of the 1.5.x branch.

Mike