Wrong phpdoc return type for Net_DNS2_Resolver:query()

mikepultz / netdns2

Native PHP DNS Resolver and Updater

https://netdns2.com/

Other

119 stars 64 forks source link

Wrong phpdoc return type for Net_DNS2_Resolver:query() #92

Closed hluaces closed 5 years ago

hluaces commented 5 years ago

My IDE warned me about a type mismatch on some operations and I found out that Net_DNS2_Resolver:query() returns the response obtained from Net_DNS2:sendPacket() which happens to be a Net_DNS2_Packet_Response object, or false on error.

This makes the phpdoc on Net_DNS2_Resolver:query() incorrect, as it states that the method returns a Net_DNS2_RR object and thus raises the inspections warnings.

Not a big deal but reporting it nevertheless.

mikepultz commented 5 years ago

thanks @hluaces - I'll add it to my list!

Cheers,

Mike

mikepultz commented 5 years ago

fixed; will be in the next release.

Mike