Address thread-safety issues by removing backtrace logger

miker2 / flexi_config_reader

A flexible configuration format that supports templated tables and referencing of existing keys.

MIT License

3 stars 1 forks source link

Address thread-safety issues by removing backtrace logger #147

Closed jayv closed 1 week ago

jayv commented 1 week ago

The logger maintained a history for logging a backtrace in case of errors, this wasn't thread-safe, rather costly and currently unused so we've decided to remove it.

Fixes #139

This is an alternative to #140 to avoid introducing locks

Before:

After:

jayv commented 1 week ago

We keep running into clang-tidy-13 flakyness wrt gtest on ubuntu20 builds. Observing the same in docker as well as on CI. On ubuntu22 I haven't seen it fail the build yet (there is a cmake directive, perhaps this doesn't work reliably on older cmake) . clang-tidy-13 with gtest is an issue AFAIR from clang-tidy-14 it works better. I've moved clang-13 to ubuntu22 to unblock...