miker2049 / midigrid

A helper library for midi grids and monome norns
GNU General Public License v3.0
63 stars 33 forks source link

Thoughts on OOP redesign, leveraging norns grid API #12

Open tildebyte opened 4 years ago

tildebyte commented 4 years ago

@miker2049, @jaggednz, @timm052; PTAL cc @catfact, @ryanlaws

What I had in mind was e.g.

├── lib
│   ├── mg_128.lua
│   ├── mg_256.lua
│   ├── mg_64.lua
│   └── midigrid.lua

where midigrid.lua contains only code common to all grid sizes.

This starts to suggest an OOP appproach, with midigrid.lua containing a midigrid ABC, mg_64.lua containing a 64-key child class, etc.

Having looked at @okyeron's oscgrid, very specifically oscgrid.lua, it occured to me that we might be able to similarly leverage the existing norns grid API for the implementation.

I don't know that I have the Lua know-how (or unfortunately the time) right now to do the design work, but I'm certainly willing to talk about it, and pick up coding tasks which might come out of this.

okyeron commented 4 years ago

Oh man - that oscgrid stuff is a huge half-baked hack. I'm kinda waiting to see what midigrid was gonna do then see if it applied to oscgrid.

tildebyte commented 4 years ago

LMFAO!