migrated code in dataset to cljc

mikera / core.matrix

core.matrix : Multi-dimensional array programming API for Clojure

Other

701 stars 113 forks source link

migrated code in dataset to cljc #327

Closed shark8me closed 6 years ago

shark8me commented 7 years ago

making the dataset API run on JSVM.

pass all dataset tests on JVM
pass all except 3 dataset tests on JSVM
"mvn package" works (locally)
"lein test" runs JVM and JSVM tests
JSVM tests run on nashorn

mikera commented 7 years ago

Hi Kiran, the Travis CI build is failing. Can you check why? In general, I won't merge a PR unless the build is working.

It's possible that the Travis environment has been updated, this has broken things before, but in this case need to identify why.

shark8me commented 7 years ago

The Travis build passes if libfortran3 is installed as a prerequisite. However, the pom.xml is not generated from the current project.xml (since it injects the wrong scm information). Therefore the test run by "mvn -B test" will only run tests for JVM and not the JSVM.