Port code to cljs fixing warnings related to numeric and object types.

mikera / core.matrix

core.matrix : Multi-dimensional array programming API for Clojure

Other

700 stars 113 forks source link

Port code to cljs fixing warnings related to numeric and object types. #334

Closed whilo closed 4 years ago

whilo commented 6 years ago

This fixes a bunch of unported ClojureScript call-sites that clutter my build logs with warnings. I still get errors from the doseq-indexed, but couldn't figure out yet why it is not expanding correctly. I would suggest using https://github.com/cgrand/macrovich for macro definition and expansion, as it would allow core.matrix also to be loadable in self-hosted ClojureScript. I am not sure whether this is currently possible(?).

bendlas commented 5 years ago

@mikera can we get this merged, or at least vetted?

mikera commented 4 years ago

Hi all, sorry for the delay not looked at this repo for a while!

All looks fine to me, though I don't use core.matrix with ClojureScript so probably not the best person to review or test. If anyone wants a new release, happy to make one.