search

mikera / core.matrix

core.matrix : Multi-dimensional array programming API for Clojure
Other
700 stars 113 forks source link

Typo in persistent_vector.cljc (vector-dot)? #346

Closed glchapman closed 3 years ago

glchapman commented 3 years ago

In the following code from persistent_vector.cljc, it looks like one of the dimensionality calls should target a (instead of both targeting b):

(extend-protocol mp/PVectorOps
  #?(:clj IPersistentVector :cljs PersistentVector)
    (vector-dot [a b]
      ;; optimised vector-dot for persistent vectors, handling 1D case
      (let [dims (long (mp/dimensionality b))]
        (cond
          (and (== dims 1) (== 1 (long (mp/dimensionality b))))
mikera commented 3 years ago

Yes that look like a good spot! Fixed in latest develop branch

mikera commented 3 years ago

Thanks for the report!