what is the purpose of 'unimplemented' function in utils

mikera / core.matrix

core.matrix : Multi-dimensional array programming API for Clojure

Other

700 stars 113 forks source link

what is the purpose of 'unimplemented' function in utils #349

Open irfn opened 3 years ago

irfn commented 3 years ago

I don't see usages of unimplemented function anywhere in the codebase. src/main/clojure/clojure/core/matrix/utils.cljc If there is no specific use, I would suggest removing this method.

The reason I ask is that this method adds a clojure.reflect dependency that I would like to avoid as I am trying to use core.matrix using https://github.com/borkdude/sci which is a lightweight interpreter.

mikera commented 3 years ago

Happy to take a PR to remove this. It was mostly useful during early development, when a lot of code paths needed to be completed.

irfn commented 3 years ago

will send a PR. thanks!