search

mikera / core.matrix

core.matrix : Multi-dimensional array programming API for Clojure
Other
699 stars 113 forks source link

Add set-0d to PZeroDimensionAccess #54

Closed si14 closed 11 years ago

si14 commented 11 years ago

I think we should add add-0d (non-mutative one) to PZeroDimensionAccess for consistency.

mikera commented 11 years ago

It's an odd one: arguably it isn't needed since set-0d can just return the scalar value it is passed.... see the 1-arity implementation for clojure.core.matrix/mset for example.

Fine to add it though for completeness sake, we may find a use for it in the future.

mikera commented 11 years ago

Fixed here: https://github.com/mikera/matrix-api/commit/bb9250e88910428dd5c2e5540992e7a069424e53