combiner vector-norm and matrix-norm into a single norm method.

mikera / vectorz-clj

Fast matrix and vector maths library for Clojure - as a core.matrix implementation

203 stars 19 forks source link

combiner vector-norm and matrix-norm into a single norm method. #35

Closed prasant94 closed 10 years ago

prasant94 commented 10 years ago

FAIL in (compliance-test) (compliance_tester.clj:763)
expected: (= (row-count R) 2)
  actual: (not (= 4 2))

This is one of the older tests. I barely added anything, that shouldn't have affected it.

mikera commented 10 years ago

Can you investigate? Might be an invalid assumption. Or I might have broken something with my recent changes.... try running the code from the test at the REPL and see what you get.

prasant94 commented 10 years ago

its the compact option for QR decomposition...vectorz-clj didn't support that until now. I'll add it.

prasant94 commented 10 years ago

yup...good to go

mikera commented 10 years ago

Looks good, thanks!