non-zero-indices fails on >1d arrays

mikera / vectorz-clj

Fast matrix and vector maths library for Clojure - as a core.matrix implementation

203 stars 19 forks source link

non-zero-indices fails on >1d arrays #41

Closed drone29a closed 10 years ago

drone29a commented 10 years ago

The default implementation (in default.clj) of PNonZeroIndices will invoke the array/matrix as a function when attempting to get the non-zero indices for an inner dimension.

drone29a commented 10 years ago

As an aside, I've run into a number of issues with sparse matrices in Vectorz and core.matrix. Still sorting them out and will report and fix later.

mikera commented 10 years ago

OK thanks for the report! Sparse matrix support is still a bit experimental, so any help you can give is much appreciated!

Definitely seems like a bug to me.... root cause is probably in core.matrix rather than vectorz-clj, although vectorz.clj should have a fast override of PNonZeroIndices

mikera commented 10 years ago

Fixed in latest release I think.