search

mikereedell / sunrisesunsetlib-java

Library for computing the sunrise/sunset from GPS coordinates and a date, in Java.
http://mikereedell.github.com/sunrisesunsetlib-java/
Apache License 2.0
299 stars 69 forks source link

adjustForDST to respect getDSTSavings #19

Closed forrestguice closed 7 years ago

forrestguice commented 7 years ago

contains both potential fixes described in #18

  1. dst offset of getDSTSavings
  2. dst offset of date.getTimeInMillis()) - timeZone.getRawOffset()
nuk commented 7 years ago

Seems ok to me, but it'd be nice to have the tests to cover such cases.

forrestguice commented 7 years ago

It doesn't look like this pull will be accepted any time soon. Also in retrospect I don't like the way I submitted it - I should have made a branch. ...closing it.