search

mikescamell / shared-element-transitions

Source code for a blog post series on Shared Element Transitions in Android
http://bit.ly/sharedelementtransitions
MIT License
284 stars 73 forks source link

postponeEnterTransition() does not work in "Picasso Fragment to Fragment" sample. #8

Open aartikov opened 7 years ago

aartikov commented 7 years ago

Calling of a method postponeEnterTransition() has no effect. To check it remove startPostponedEnterTransition() calls in a Picasso callback. A transition will be still plays, but it should not. Documentation says: "Likewise, postponement only works if FragmentTransaction optimizations are enabled." So, to fix the sample call setAllowOptimization(true) of a FragmentTransaction.

Rainer-Lang commented 7 years ago

@aartikov Do you want to make a PR?

aartikov commented 7 years ago

@Rainer-Lang No, i don't. It is looks like that this repository is abandoned.

mikescamell commented 7 years ago

@aartikov It's not abandoned, I'm just pretty busy at the moment. Feel free to make a PR.

aartikov commented 7 years ago

@mikescamell done #11

mikescamell commented 7 years ago

@aartikov I'm going to need to look into this more as turning the optimisation on has an effect on the Shared Element Transitions.