search

mikeseven / node-opencl

Low-level OpenCL 1.x and 2.x bindgings for node.js
156 stars 33 forks source link

Update for node 12 (wip) #71

Closed lmeyerov closed 4 years ago

lmeyerov commented 4 years ago

Updates node-opencl for node 12.11 / nan 2.10:

Blockers

Nice-to-have

Overall changes: -- Garden: separate out dev deps (speed + work around memwatch), update packagelock -- Nan updates <-- worth checking https://github.com/mikeseven/node-opencl/pull/71/commits/c3b201a95874059393e7b5d7ac287fc3be067b37, I called out the basic forms repeated in it in the comments -- Disable memwatch tests as memwatch does not build -- Update gc flag

Will test on-and-off. Only have intel + nvidia hw for testing, w/ nvidia being our primary goal.

Happy to help get upstream, though limited bandwidth. Maybe package as node-opencl-next in the meanwhile.

lmeyerov commented 4 years ago

cc @mikeseven Let me know how you'd like this to be handled

lmeyerov commented 4 years ago

Ah, just saw https://github.com/trxcllnt/node-opencl/pull/1 ... looking.

lmeyerov commented 4 years ago

Yeah, created combined branch w/ latest updates from @lu4 / @trxcllnt => https://github.com/graphistry/node-opencl#next .

trxcllnt commented 4 years ago

https://github.com/mikeseven/node-opencl/pull/69

lmeyerov commented 4 years ago

100%, redid https://github.com/graphistry/node-opencl/commits/next to add the next 2 @lu4 commits + dug into one of the failing tests.. will close this and refile

lmeyerov commented 4 years ago

Moved to https://github.com/mikeseven/node-opencl/pull/69 as https://github.com/trxcllnt/node-opencl/pull/3