Ensure member search can not block on large searches
Related Discussions/Issues
@DiscordLiz
While I agree with the sentiment that sourcery provided bad advice and that it over-rated the complexity, I still did see this is a place for improvement. Depending on where their cutoff is for branching, sourcery probably would still see this version as an issue, but I don't really care as that was not the goal of this change.
This repeats less work at the cost of some function calls. Considering the most common uses of this filter use 3 or fewer conditions from a filter that supports much more, I consider this acceptable without timing.
Had it not been for the repeated iterations over a member list here, I probably would have left it without modification for now., but this was as good a time as any to get around to this.
Description of Changes
Related Discussions/Issues
@DiscordLiz While I agree with the sentiment that sourcery provided bad advice and that it over-rated the complexity, I still did see this is a place for improvement. Depending on where their cutoff is for branching, sourcery probably would still see this version as an issue, but I don't really care as that was not the goal of this change.
This repeats less work at the cost of some function calls. Considering the most common uses of this filter use 3 or fewer conditions from a filter that supports much more, I consider this acceptable without timing.
Had it not been for the repeated iterations over a member list here, I probably would have left it without modification for now., but this was as good a time as any to get around to this.