search

mikespub-org / seblucas-cops

Calibre OPDS (and HTML) PHP Server : web-based light alternative to Calibre content server / Calibre2OPDS to serve ebooks (epub, mobi, pdf, ...)
http://blog.slucas.fr/en/oss/calibre-opds-php-server
GNU General Public License v2.0
55 stars 7 forks source link

Kindle stylesheet opinion #56

Closed dunxd closed 9 months ago

dunxd commented 9 months ago

I noticed that the Kindle style for the default theme includes code insert a credit at the end of the page:

https://github.com/mikespub-org/seblucas-cops/blob/111d4e9da164d1e1f15cf947b5ddf454843398b0/templates/default/styles/style-kindle.css#L488-L513

I'm all for giving credit where credit is due, but it is more prominent than credits to seblucas or anyone else involved, and using unicode characters to obscure the text in source doesn't sit right with me.

Have I just got up on the wrong side of the bed this morning?

dunxd commented 9 months ago

However it has got me thinking about using unicode characters in place of icons for my planned kindle oriented template.

mikespub commented 9 months ago

Heh - guess credits aren't all bad then :-)

I just included the style from https://github.com/Joduai/cops-kindle without any changes when I came across it, as I have no Kindle to test this on and I'm probably not the best person to judge front-end styles. Maybe you and/or @Joduai can improve on it for future releases?

dunxd commented 9 months ago

See #59