mikespub-org / seblucas-cops

Calibre OPDS (and HTML) PHP Server : web-based light alternative to Calibre content server / Calibre2OPDS to serve ebooks (epub, mobi, pdf, ...)
http://blog.slucas.fr/en/oss/calibre-opds-php-server
GNU General Public License v2.0
55 stars 7 forks source link

No large book covers and white screen with vienwer #73

Closed marioscube closed 4 months ago

marioscube commented 5 months ago

Running:

Error 1:

Error 2

Am I doing something wrong?

mikespub commented 4 months ago

There was an error for multi-database that should be fixed in the latest release 2.2.2, but that was only for epub reader and email.

I'm not sure I understand the errors you mentioned here - what did you mean by selecting a book cover and scroll horizontally for Error 1, and what did you mean by "selecting view icon" only for Error 2?

marioscube commented 4 months ago

I will install version 2.2.2 tomorrow and report back.

I like to fix 1 error at a time ;-)

marioscube commented 4 months ago

@mikespub Error 2 is resolved! Thank you!

Error 1 (additional explanation):

In the legacy COPS I could click on a cover in this view: Screenshot 2024-02-19 at 11 54 29 and get this screen with large covers (note the triangles on both sides). In this screen I could scroll horizontally through all covers. I think this is a handy feature. Screenshot 2024-02-19 at 11 57 30

Selecting a book goes through clicking on the title (not on the cover/icon).

I like my old COPS back ;-)

Keep up the great work!!!

mikespub commented 4 months ago

Hi @marioscube - about Error 1 that's what I thought you meant, and it's a nice feature indeed :-)

But here's my problem: in the original COPS code at https://github.com/seblucas/cops and further releases here at https://github.com/mikespub-org/seblucas-cops there is no code, template or javascript that supports this...

Can you find out which version you were based on, and if there was anything customized after this version from elsewhere, so that I can recreate this?

Thanks

marioscube commented 4 months ago

@mikespub

In this version it still worked: Screenshot 2024-02-19 at 13 18 44

marioscube commented 4 months ago

@mikespub

Changes in ../cops/templates/default/main.html and or ../cops/templates/default/bookdetail.html seem to be the cause.

mikespub commented 4 months ago

Aha, we're getting closer - between 1.4.2 and 1.4.3 I did indeed switch the link on the thumbnail image in the main.html template from coverURL (fetch.php?id=...) to detailURL (index.php?page=13&id=...), because ... in the main navigation it made more sense to point to the detail page and it seemed pointless to link to a cover image by itself.

Of course, at that point I did not have that functionality with previous & next buttons in the interface that you showed here either - so I still don't know if & when that actually disappeared.

Did you have any other customization of templates or javascript by any chance, or do you still have this working with 1.4.2?

marioscube commented 4 months ago

@mikespub

That functionality has been in COPS since almost forever.

If I, just for testing purposes, copy the html files from version 1.4.2 to version 2.2.2 this works again. I might then be missing out on new functionality though.

mikespub commented 4 months ago

Thanks for the clarifications & screenshots. When trying to reproduce this, I noticed that you used the "Lightbox" option (magnific popup) for the default template, which actually still works for 2.2.2+ when it gets the right cover url - now fixed with the changes above :-)

marioscube commented 4 months ago

@mikespub

I have my old COPS back, now working with php8.

Thank you!

Issue closed!