search

mikestead / ecs-task-deploy

Update an AWS ECS task definition with Docker image and trigger a blue/green deployment
38 stars 11 forks source link

Better error message when service is not found #9

Closed koresar closed 6 years ago

koresar commented 6 years ago

If the service is missing the error shown is:

Cannot read property 'taskDefinition' of undefined

This PR changes the error message to:

Service my-service-name not found, aborting.
koresar commented 6 years ago

Hey @mikestead

Do you have a minute to review and publish the change? We continuously have Cannot read property 'taskDefinition' of undefined errors in production. The nicer error message would point our developers to what they forgot to do while releasing a service. Otherwise, they create devops tasks, complain...

mikestead commented 6 years ago

@koresar thanks for the PR and sorry for not merging sooner. Released under v1.3.1.

koresar commented 6 years ago

Thanks for quick response!