search

mikestead / hx-yaml

A cross-platform YAML 1.2 parser & renderer for Haxe.
MIT License
75 stars 28 forks source link

Fix compatibility with latest Haxe 4 #18

Closed Gama11 closed 6 years ago

Gama11 commented 6 years ago

Haxe 4 removes support for the Haxe 2 style property syntax, see HaxeFoundation/haxe#4699. With current dev builds of Haxe, this leads to the following errors:

C:\HaxeToolkit\haxe\lib\yaml/1,3,0/yaml/YamlException.hx:7: characters 2-41 : name: Custom property accessor is no longer supported, please use get
C:\HaxeToolkit\haxe\lib\yaml/1,3,0/yaml/YamlException.hx:10: characters 2-47 : message: Custom property accessor is no longer supported, please use get
mikestead commented 6 years ago

@Gama11 is this backwards compatible to previous versions of Haxe?

Gama11 commented 6 years ago

Yes, it works fine for both Haxe 3 and 4, see the issue I linked. Or do you mean compatibility with Haxe 2?

mikestead commented 6 years ago

@Gama11 Yeah just wondering if it requires a major version bump of the lib. Sounds like it does. Thanks for the PR

Gama11 commented 6 years ago

Was it previously still compatible with Haxe 2? The readme states "for Haxe 3+" at least.

mikestead commented 6 years ago

oops you're right, thanks. Thought it did but it's been a few years since I've touched haxe