Doubles same language - Githubissues

mikesteele / dual-captions

🌐 Subtitles in two languages for YouTube & Netflix

https://chrome.google.com/webstore/detail/two-captions-for-youtube/lpeonmjfimoijceaalocpgjjchocbiap/related

MIT License

229 stars 41 forks source link

Doubles same language #97

Open arman86 opened 5 years ago

arman86 commented 5 years ago

For version 2.0.

State I: New Video Just start a video. In this case: https://www.netflix.com/watch/81035324?trackId=14170286 Note English subtitles

The extension has not yet been started:

State II: Turn Dual Captions On

Note English shows up as the only other option.

Sure enough, get to see English twice:

State III: Workaround To get around the bug, go to Netflix subtitle selection and choose the other language:

mikesteele commented 5 years ago

Hey! I think Spanish and English captions both have the word "professor", but they're not doubled.

mikesteele commented 5 years ago

Oh I get it, English loads and it's still selected on Netflix. I'll think about if there's a way to fix that.

seekM commented 4 years ago

I have the same problem with YouTube. When activating subtitles in YouTube, YouTube picks the language which you set in the YouTube settings page. Dual-captions also shows this language.

It would be cool if a) Dual-captions picked up all the captions provided by the YouTube video and shows them in the "Second Subtitle Language" box such that we can select the one we want and b) if Dual-captions allowed us to set a default language which should be selected by default in the "Second Subtitle Language" box. E.g. in my YouTube settings I have english as a default language. Therefore YouTube shows me english subtitles. I would like to set portuguese as a default langauge for Dual-captions such that Dual-captions automatically shows me portuguese subtitles (in case they are offered by the video).

mikesteele-drizly commented 4 years ago

I hear you. It's not easy though. The content_script runs in an isolated JS world, and though Netflix (and perhaps YouTube) exposes all available subtitle tracks (see this commit https://github.com/mikesteele/dual-captions/commit/b64dd478cd2891f141d468907c6dd9b9aec2698c), it's not easy to access from an isolated world, and runs the risk of breaking in the future.

This project chooses to be more conservative with regards to the host site (YouTube, Netflix, etc) than other projects because I believe that it is more maintainable over time, less fragile, and more adaptable to more websites.

seekM commented 4 years ago

Thanks for the response (and for the add-on, of course)! I understand. I guess for long Netflix movie this less inconvenient than for ~2-3 minutes long YouTube videos when this manual process has to be done for each new video. I'll see if I can automate this process via other means (e.g. Sikuli).

mikesteele-drizly commented 4 years ago

I appreciate the feedback and I'll keep this in mind. My next priorities for the project for uploading custom SRT files, Amazon support, and Google Translation support.