base.py uses "unicode" - Githubissues

miketeo / pysmb

pysmb is an experimental SMB/CIFS library written in Python. It implements the client-side SMB/CIFS protocol (SMB1 and SMB2) which allows your Python application to access and transfer files to/from SMB/CIFS shared folders like your Windows file sharing and Samba folders.

Other

338 stars 95 forks source link

base.py uses "unicode" #17

Closed keisetsu closed 9 years ago

keisetsu commented 9 years ago

unicode() is deprecated in 3. I will try to post a pull request, but simply replacing "unicode(" with "str(" should fix this, I believe.

A side note: in testing, I noticed that v1.1.12 targeted for python 3.2 still contains regular strings for bytes. In 3.3 and 3.4 this isn't a problem. Not sure if there is a reason for the difference.

miketeo commented 9 years ago

@keisetsu : Ok, thanks for bring this to my attention. To be honest, pysmb is not as well-tested for python3 as for python2. I will look into this over the next few days.