miketheprogrammer / go-thrust

Cross Platform UI Kit powered by Blink/V8/Chromium Content Lib
MIT License
445 stars 34 forks source link

Refactor `NewWindow` by using struct #55

Closed odknt closed 9 years ago

odknt commented 9 years ago
miketheprogrammer commented 9 years ago

I love it, however I have to leave it as a pull request until I have time to change the examples. Unless you would like to refactor the examples as well.

I will hopefully be resuming work on this for now. Until then, or until you refactor the examples, I hope people whom need this functionality will see this pull request and pull your fork.

Thanks for the work.

odknt commented 9 years ago

@miketheprogrammer Thanks for checking.

I changed examples and tutorials. Adding to the above, I changed has_frame to conform specification below.

https://github.com/breach/thrust/blob/master/docs/api/window.md

  • has_frame creates a frameless window if true
miketheprogrammer commented 9 years ago

Merging. Thanks.