enable icon_path (for windows builds)

miketheprogrammer / go-thrust

Cross Platform UI Kit powered by Blink/V8/Chromium Content Lib

MIT License

445 stars 34 forks source link

enable icon_path (for windows builds) #75

Closed jheuel closed 8 years ago

jheuel commented 8 years ago

Because IconPath was missing in CommandArguments, this feature could not be used

miketheprogrammer commented 8 years ago

Wow sorry i missed this. Reviewing now

miketheprogrammer commented 8 years ago

LGTM.

miketheprogrammer commented 8 years ago

@jheuel Actually, I am going to consider reverting, because it is not currently cross platform. Since commands.go is used in all builds, it would be bad to have it not utilized crossplatform

miketheprogrammer commented 8 years ago

gotta look at the thrust source code and confirm.